Pixelmon Mod - Bug tracker

[7.0.6] Potential incorrect biome ids found in default spawner config files. fix completed for upcoming version

Ticket description:
(Note: in regards to the "one bug per report" rule, since these issues pertain to minor errors found in config files, as to not clutter your bug tracker with multiple tickets that are almost identical, I have collected all of the issues I've found into this ticket)

I have identified potential issues present in the default spawn configurations for Pixelmon Reforged, as of version 7.0.6. Listed below are the issues I've found in each of the files.

Code: Select allspawning/fishing/Tympole Line Fishing.set.json
This file has a reference to the biome or category rivers. However, that biome does not exist anywhere in the Biome IDs of Vanilla Minecraft, Biomes O' Plenty, RealWorld, Traverse, or Pixelmon, nor is it a registered biome category in BetterSpawnerConfig.json. It is the only spawn config file with a reference to rivers (note the s at the end). Unless I am mistaken, this should probably be changed to river.


Code: Select allspawning/grass/Gligar Line Grass.set.json
This file has a typo - temparate_rainforest should be changed to temperate_rainforest


Code: Select allspawning/standard/Avalugg.set.json
spawning/standard/Bergmite.set.json
These files have references to the biome or category freezing_mountains - note the underscore. All other spawn config files, and BetterSpawnerConfig.json, use freezing mountains instead - with a space instead of an underscore. These two spawn config files are the only two that contain freezing_mountains with an underscore. Perhaps these references should be changed to freezing mountains.


Code: Select allpixelmon/spawning/grass/Komala Grass.set.json
pixelmon/spawning/standard/Komala.set.json
BetterSpawnerConfig.json
These files have a reference to arid_highlands. Note the s at the end. This is supposedly a reference to one of Traverse's biomes, however the actual programmatic biome ID does not have an s at the end. The correct biome id is traverse:arid_highland:

https://github.com/Prospector/Traverse/ ... .java#L142

Interestingly, all other spawn configs have it correct as arid_highland. These files are the only ones with the issue. Perhaps these references should be changed to arid_highland.


Code: Select allspawning/npcs/relearners.set.json
spawning/npcs/shopkeepers.set.json
spawning/npcs/traders.set.json
spawning/npcs/trainers.set.json
spawning/npcs/tutors.set.json
These files have a reference to the biome or category ice_plains, which is presumably a Vanilla Minecraft biome. However, minecraft:ice_plains does not exist, while minecraft:ice_flats does. I am not sure if this is actually an issue, or if the Pixelmon code and/or Forge handles this dynamically. Vanilla Minecraft's registry ID for this biome is in fact ICE_PLAINS, so this may not be an issue after all. I thought this was worth mentioning regardless.


Code: Select allBetterSpawnerConfig.json
    Under the beaches biome category, there is a reference to origin_island_shore. Presumably, this is a reference to a Biomes O' Plenty biome. However, as far as I can tell, the biome id biomesoplenty:origin_island_shore does not exist. In fact, searching for this string on Google will yield only one result - the "Beaches" page on the Pixelmon Wiki. Biomes O Plenty does, however, have a biome with an id of biomesoplenty:origin_beach, which is formed when a biomesoplenty:origin_island biome meets an ocean biome. Perhaps the string origin_island_shore in BetterSpawnerConfig.json should be changed to origin_beach.

    There are two references to rw_silver_birch_forest in this file. However, unless I am mistaken, this biome id does not appear to exist in the mod it is from, RealWorld. There are no references to any "Silver Birch Forest" on that mod's homepage, nor in that mod's .jar. Additionally, if you Google the string "realworld:rw_silver_birch_forest," the only result will be the "All Forests" page on the Pixelmon Wiki. The closest valid biome id to this would be realworld:rw_silver_birch_hills. Since all reference to rw_silver_birch_forest are adjacent to rw_silver_birch_hills, which is a valid biome id for the RealWorld biome, perhaps both references to rw_silver_birch_forest should be removed.

    There is a reference to the biome polar_chasm, presumably belonging to Biomes O' Plenty. However, this biome was removed from Biomes O Plenty and no longer exists. Perhaps it should be removed from this file (Source: https://biomesoplenty.fandom.com/wiki/Polar_Chasm)

    There is a reference to the biome lavender_field, presumably belonging to Biomes O' Plenty, however this is a typo - this biome ID should include an s at the end. The fully qualified biome id for this biome is biomesoplenty:lavender_fields. Perhaps this instance of lavender_field should be changed to lavender_fields.

    Under the freezing mountains biome category, there is a reference to the biome minecraft:mutated_cold_taiga. However, this is not the correct biome id - the correct biome id is minecraft:mutated_taiga_cold. Perhaps minecraft:mutated_cold_taiga should be changed to minecraft:mutated_taiga_cold

    Under the taigas and all forests biome categories, there are references to the biome traverse:coniferous_forest. However, unless I am mistaken, this biome id does not exist in the Traverse mod. The closest valid biome id to this would be either traverse:snowy_coniferous_forest or traverse:temperate_rainforest. I am not sure which biome was originally intended in either instance, though the reference in the taigas category likely intended the snowy variant. Due to the ambiguity between these two biomes, you may find this Traverse commit to be of interest:

    https://github.com/Prospector/Traverse/ ... 9df795c3e3

    Under the forests and all forests biome categories, there are references to the biome biomesoplenty:thicket. However, this biome was removed from Biomes O' Plenty and no longer exists. Perhaps it should be removed from this file (Source: https://biomesoplenty.fandom.com/wiki/Thicket)

Comments

#18488 Posted by ubergeek77 » 06 Jun 2019 14:28

My apologies, but I seemed to have missed just one more:

in BetterSpawnerConfig.json, under the arid section, there is a reference to the biome desert_oasis, presumably a Biomes O' Plenty biome. As far as I can tell, the biome id biomesoplenty:desert_oasis does not exist. However, the biome id biomesoplenty:oasis does exist, and as a sub-biome of the vanilla desert biome, it fits the description of being a "Desert Oasis:"

https://biomesoplenty.fandom.com/wiki/Oasis

Perhaps desert_oasis should be changed to just oasis.

#18508 Posted by wop0911 » 09 Jun 2019 09:56

Some of these things are already fixed and can be seen with a regen of the files. BoP biomes will be maintained for a limited amount of time due to people still using older versions. The rest of the tweaks needed will be handled. Thank you once again for your report and if you see anything else please do let us know.

#18510 Posted by ubergeek77 » 10 Jun 2019 13:36

Thank you for your response.

In regards to:

Some of these things are already fixed and can be seen with a regen of the files.


While you undoubtedly know more about the development process of Pixelmon than I do, I should mention that all of the configs I pulled in order to make this ticket were extracted directly from the assets directory of the 7.0.6 Server Pixelmon .jar. With that in mind, there is nothing to "regen," as these are the base, default files present in the .jar. If they should have already been fixed in this location, you may want to double check.

#18536 Posted by MattBlower » 22 Jun 2019 16:13

fixed for next version

#18537 Posted by wop0911 » 22 Jun 2019 16:14

Can confirm that what needed to be fixed should be good to go for the upcoming release. There was a couple files that should have been fixed in the current version, but if you happen to see anything else following the next release please do let us know.

Ticket details

  • Ticket ID: 13805
  • Project: Pixelmon Mod
  • Status: Fix completed for upcoming version
  • Component: Spawning
  • Project version: 7.x.x
  • Priority: Normal
  • Severity: Normal
  • Forge/Sponge: (unknown)
  • What else would be useful to know?: (unknown)
  • Assigned to: (unassigned)
  • Reported by: ubergeek77
  • Reporter's tickets: (List all tickets)
  • Reported on: 05 Jun 2019 18:51
  • Ticket last visited by: MattBlower on 22 Jun 2019 16:13